Skip to content

Conversation

@yixinguo-ssc
Copy link

Summary

Fix Issue 14421
grpc-gateway fails to load proto file with message "proto3 disallow 'optional' label"

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[14421](#14421)

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

StarlightIbuki
StarlightIbuki previously approved these changes Jun 4, 2025
@StarlightIbuki
Copy link
Contributor

With 1 more approval I will add change log for this

Oyami-Srk
Oyami-Srk previously approved these changes Jun 5, 2025
Copy link
Member

@Oyami-Srk Oyami-Srk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution! 🚀

@yixinguo-ssc
Copy link
Author

With 1 more approval I will add change log for this

@StarlightIbuki PR now has 2 approvals. Could you add change log please?

@StarlightIbuki
Copy link
Contributor

@yixinguo-ssc I don't have write access to your branch. You could add a changelog file to changelog/unreleased/kong/fix-missing-grpc-optional-support.yml with content below:

message: Fixed an issue where gRPC plugins lack support for "optional".
scope: Plugins
type: bugfix

@StarlightIbuki
Copy link
Contributor

@yixinguo-ssc Sorry for the misleading info. Please correct the changelog:

message: Fixed an issue where gRPC plugins lack support for "optional".
scope: Plugin
type: bugfix

    When grpc-gateway plugin loads a proto3 proto file with optional labeled fields, it will throw an error "proto3 disallow 'optional' label". This fixes the issue by enabling proto3_optional in protoc.
@yixinguo-ssc
Copy link
Author

@StarlightIbuki updated changelog

@yixinguo-ssc
Copy link
Author

@StarlightIbuki I'm still getting

Merging is blocked
You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.

@StarlightIbuki
Copy link
Contributor

@yixinguo-ssc Thanks for keeping track. Currently, we are confirming with people, and pending a response to merging this. The PR is ready and requires no more action from your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/community PRs from the open-source community (not Kong Inc) size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grpc-gateway fails to load proto file with message "proto3 disallow 'optional' label"

5 participants